Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network load balancer example for specified internal IP address #742

Merged

Conversation

AlanHohn
Copy link
Contributor

@AlanHohn AlanHohn commented Oct 2, 2021

SUMMARY

Adds an example to community.aws.elb_network_lb for creating an internally-facing ELB
with a specified internal IP address.

The subnet_mappings dictionary is passed directly through to the AWS ELB API, so the
ability was inherent in the module but wasn't documented.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

community.aws.elb_network_lb

ADDITIONAL INFORMATION

No module change, just docs. Happy to make any requested changes. Thanks for this module
and for looking at the PR.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Oct 2, 2021
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble tremble added the gate label Oct 19, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit cb5e541 into ansible-collections:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants